Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove brp-elfperms script #3324

Merged

Conversation

sshedi
Copy link
Contributor

@sshedi sshedi commented Sep 23, 2024

This is done based on discussion at:
#3195

This is done based on discussion at:
rpm-software-management#3195

Signed-off-by: Shreenidhi Shedi <[email protected]>
@sshedi sshedi requested a review from a team as a code owner September 23, 2024 10:16
@sshedi sshedi requested review from ffesti and removed request for a team September 23, 2024 10:16
@ffesti
Copy link
Contributor

ffesti commented Sep 24, 2024

Patch itself looks good. @pmatilai is this what you had in mind?

@pmatilai
Copy link
Member

Well in #3195 I was talking about disabling it by default, on Linux.

@sshedi
Copy link
Contributor Author

sshedi commented Sep 24, 2024

@pmatilai can you please give some more info? I will fix the patch accordingly. From my understanding, this script runs only on Linux. --shared flag to eu-elfclassify affects only shared objects. Any other platform uses shared objects? 🤔

@pmatilai
Copy link
Member

Um, the whole unix-like world is using ELF, and yes including shared objects.

But I just realized, there's a gotcha here: elfutils, which the script relies on, is a Linux-only project by their own declaration: https://sourceware.org/elfutils/ says it quite explicitly.

So disabling the script as-is on Linux and shipping for other platforms would be hilariously absurdly pointless.
Since we lack the equivalent of eu-elfclassify in non-Linux tooling, we can just as well delete the whole thing.

@pmatilai pmatilai merged commit bcf06fd into rpm-software-management:master Sep 25, 2024
1 check passed
@pmatilai
Copy link
Member

So, thanks for the patch 😄

@sshedi
Copy link
Contributor Author

sshedi commented Sep 25, 2024

Thanks for taking the fix. 🙏

@sshedi sshedi deleted the brp-elfperms-removal branch September 25, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants